code-review

작성자: sentry

Sentry 엔지니어링 관행을 따르는 코드 리뷰 프레임워크로, 풀 리퀘스트 및 코드 품질 평가를 위한 것입니다. 런타임 오류, 성능 병목 현상, 부작용, 하위 호환성, ORM 쿼리 문제, 보안 취약점 등 여섯 가지 주요 문제 영역을 다룹니다. 구성 요소 상호 작용, 아키텍처 정렬, 요구 사항 충돌에 대한 설계 평가 지침을 포함합니다. 기능, 통합, 엔드 투 엔드 테스트 전반에 걸쳐 적절한 테스트 범위를 요구하며, 엣지 케이스 검증을 포함합니다.

npx skills add https://github.com/getsentry/skills --skill code-review

ZIP 다운로드 GitHub

896

Sentry Code Review

Follow these guidelines when reviewing code for Sentry projects.

Review Checklist

Identifying Problems

Look for these issues in code changes:

Runtime errors: Potential exceptions, null pointer issues, out-of-bounds access
Performance: Unbounded O(n²) operations, N+1 queries, unnecessary allocations
Side effects: Unintended behavioral changes affecting other components
Backwards compatibility: Breaking API changes without migration path
ORM queries: Complex Django ORM with unexpected query performance
Security vulnerabilities: Injection, XSS, access control gaps, secrets exposure

Design Assessment

Do component interactions make logical sense?
Does the change align with existing project architecture?
Are there conflicts with current requirements or goals?

Test Coverage

Every PR should have appropriate test coverage:

Functional tests for business logic
Integration tests for component interactions
End-to-end tests for critical user paths

Verify tests cover actual requirements and edge cases. Avoid excessive branching or looping in test code.

Long-Term Impact

Flag for senior engineer review when changes involve:

Database schema modifications
API contract changes
New framework or library adoption
Performance-critical code paths
Security-sensitive functionality

Feedback Guidelines

Tone

Be polite and empathetic
Provide actionable suggestions, not vague criticism
Phrase as questions when uncertain: "Have you considered...?"

Approval

Approve when only minor issues remain
Don't block PRs for stylistic preferences
Remember: the goal is risk reduction, not perfect code

Common Patterns to Flag

Python/Django

# Bad: N+1 query
for user in users:
    print(user.profile.name)  # Separate query per user

# Good: Prefetch related
users = User.objects.prefetch_related('profile')

TypeScript/React

// Bad: Missing dependency in useEffect
useEffect(() => {
  fetchData(userId);
}, []);  // userId not in deps

// Good: Include all dependencies
useEffect(() => {
  fetchData(userId);
}, [userId]);

Security

# Bad: SQL injection risk
cursor.execute(f"SELECT * FROM users WHERE id = {user_id}")

# Good: Parameterized query
cursor.execute("SELECT * FROM users WHERE id = %s", [user_id])