pr-operations作者: dagster-io

Use when working with PR review comments, resolving threads, or replying to discussion comments. Essential for understanding the correct erk exec commands for…

npx skills add https://github.com/dagster-io/erk --skill pr-operations

PR Operations Skill

Core Rule

CRITICAL: Use ONLY erk exec Commands for PR Thread Operations

  • ❌ DO NOT use raw gh api calls for thread operations
  • ❌ DO NOT use gh pr commands directly for thread resolution
  • ✅ ONLY use erk exec commands listed below

The erk exec commands handle thread resolution correctly. Raw API calls only reply without resolving.

Quick Reference

CommandPurposeKey Point
get-pr-review-commentsFetch unresolved review threadsReturns threads with line info
get-pr-discussion-commentsFetch PR discussion commentsReturns top-level comments
resolve-review-threadReply AND resolve a single threadDoes both in one operation
resolve-review-threadsBatch resolve multiple threadsJSON stdin, one call for N threads
reply-to-discussion-commentReply to discussion commentFor non-code feedback
post-pr-inline-commentPost new inline commentCreates new review thread

When to Use Each Command

Fetching Comments

# Get all unresolved review threads (code comments)
erk exec get-pr-review-comments

# Get all discussion comments (top-level PR comments)
erk exec get-pr-discussion-comments

# Include resolved threads (for reference)
erk exec get-pr-review-comments --all

Resolving Review Threads

# Resolve a single thread
erk exec resolve-review-thread --thread-id "PRRT_abc123" --comment "Fixed in commit abc1234"

# Batch resolve multiple threads (preferred for pr-address batches)
echo '[{"thread_id": "PRRT_abc", "comment": "Fixed"}, {"thread_id": "PRRT_def", "comment": "Applied"}]' | erk exec resolve-review-threads

Replying to Discussion Comments

# For PR discussion comments (not code review threads)
erk exec reply-to-discussion-comment --comment-id 12345 --reply "**Action taken:** Updated the docs as requested."

Common Mistakes

MistakeWhy It's WrongCorrect Approach
Using gh api repos/.../comments/{id}/repliesOnly replies, doesn't resolveUse erk exec resolve-review-thread
Using gh pr commentDoesn't resolve threadsUse erk exec resolve-review-thread
Skipping resolution for outdated threadsThreads stay open in PRAlways resolve, even if already fixed
Generic replies like "Noted"Not useful for PR historyInclude investigation findings

Replying vs Resolving

IMPORTANT: Replying ≠ Resolving

  • Replying (via raw gh api .../replies): Adds a comment but thread stays OPEN
  • Resolving (via erk exec resolve-review-thread): Adds a comment AND marks thread as RESOLVED

Always use erk exec resolve-review-thread (single) or erk exec resolve-review-threads (batch) - they do both in one operation.

Comment Classification Model

When analyzing PR feedback, classify comments by complexity and group into batches.

Complexity Categories

  • Local fix: Single comment → single location change (e.g., "Fix typo", "Add type annotation")
  • Multi-location: Single comment → changes in multiple spots in one file
  • Cross-cutting: Single comment → changes across multiple files
  • Related: Multiple comments that inform a single unified change

Batch Ordering

Process batches from simplest to most complex:

BatchComplexityDescriptionExample
1Local fixesOne file, one location per comment"Use LBYL pattern at line 42"
2Single-file multi-locationOne file, multiple locations"Rename this variable everywhere in this file"
3Cross-cuttingMultiple files affected"Update all callers of this function"
4Complex/RelatedMultiple comments inform one change"Fold validate into prepare" + "Use union types for this"

Note: Discussion comments requiring doc updates go in Batch 3 (cross-cutting).

Batch Confirmation Flow

  • Batch 1-2 (simple): Auto-proceed without confirmation
  • Batch 3-4 (complex): Show plan and wait for user approval

Inline Comment Deduplication

When posting inline review comments, always deduplicate to prevent re-posting existing comments:

  1. Build dedup key: (file_path, line_number, body_prefix) where prefix is first 80 characters of comment body
  2. Check proximity: Match within 2-line tolerance (line 42 matches existing comments at lines 40–44)
  3. Skip duplicates: If a matching key exists, do not post the comment

This prevents the same feedback from appearing multiple times across review iterations. See Inline Comment Deduplication for full algorithm details.

Detailed Documentation

For complete command documentation including JSON output formats, options, and examples:

@references/commands.md

NotebookLM 網頁匯入器

一鍵將網頁和 YouTube 影片匯入 NotebookLM。超過 200,000 位使用者信賴。

安裝 Chrome 擴充功能