dead-dependencies

bởi redis

Tìm và an toàn loại bỏ các dependency npm không dùng ("chết") trong RedisInsight bằng công thức grep + leaf-check + build-gate. Sử dụng khi dọn dẹp dependencies,…

npx skills add https://github.com/redis/redisinsight --skill dead-dependencies

Dead Dependencies

Identify and safely remove unused npm dependencies. This is a local, interactive workflow — a scheduled report can only ever guess; confirming a dependency is dead requires grepping real usage and running the build.

Why manual (not knip/depcheck)

Static tools over-report badly in this repo and must not be trusted blindly:

  • The root package.json is a mega-manifest (UI + desktop + build + test
    • storybook + electron), so a tool scanning one area flags everything used elsewhere as "unused".
  • Lots of dependencies are referenced without an import: webpack loaders and eslint/jest/babel plugins by string in config, tools invoked from package.json scripts, runtime -r preloads, dynamic require, and ambient @types/*.
  • The webpack→Vite migration left genuinely dead build tooling behind, mixed in with false positives.

The reliable signal is: grep for usage → confirm it's a leaf → remove it and run the build gate. That is exactly how jsonpath was confirmed dead and removed (worked example at the bottom).

The recipe (per candidate)

1. Grep the whole repo for real usage

PKG=jsonpath   # the dependency to check
grep -rn "$PKG" \
  redisinsight configs scripts tests .storybook \
  --include=*.ts --include=*.tsx --include=*.js --include=*.jsx \
  --include=*.mjs --include=*.cjs --include=*.json \
  2>/dev/null | grep -v node_modules

Look for import ... from '$PKG', require('$PKG'), import('$PKG'), and bare references. Ignore unrelated substring hits (e.g. nestjs-form-data when checking form-data, or a package name appearing only in tutorial/manifest text). Zero real references → candidate for the next steps.

2. Rule out no-import usage

A clean grep is necessary but not sufficient. Check the ways a package is used without an import:

  • Config string references — search the build/test config for the bare name: .eslintrc.js, configs/webpack.config.*.ts, redisinsight/ui/vite.config.mjs, jest.config.cjs, babel.config.cjs, electron-builder.json, .mocharc*. eslint plugins, webpack loaders, and jest/mocha reporters live here.
  • package.json scripts — a tool like concurrently, lint-staged, or a reporter is "used" if a scripts entry (any workspace) invokes it.
  • Runtime preloads / dynamicnode -r <pkg>, require(variable), or a wasm/worker loader with a computed path.

3. Leaf check

npm ls "$PKG"        # in the workspace that declares it

Confirm nothing else in the tree depends on it, and note any transitive deps it uniquely pulls (removing jsonpath also dropped underscore).

4. Classify before acting

SituationAction
Plain runtime/dev dep, zero references anywhereDelete (after the gate below)
@types/x where base x bundles its own types (node_modules/x/package.json has types/typings)Delete — the DefinitelyTyped package is obsolete
@types/x that's ambient/global-only (e.g. @types/webpack-env)Keep — never imported by design
Declared in more than one workspace (package.json), used in only oneRelocate/dedupe — remove the unused declaration, never the used copy
Shadows a Node builtin (buffer, assert, …)Keep — usually a false positive
Referenced only in a config/scripts (step 2 hit)Keep

5. The gate — the only real proof

Remove it, reinstall (per the repo's dependency rules — never hand-edit package.json/lockfile, never --ignore-scripts), and verify the affected area builds:

npm uninstall "$PKG"          # in the declaring workspace; updates the lockfile
npm run type-check            # or the affected workspace's type-check
npm run test                  # / test:api, as relevant
npm run build                 # if it's a build-time dep

Green across the relevant checks = safe. Commit the package.json + package-lock.json change (see the git-safety / dependency rules in CLAUDE.md). If anything goes red, it wasn't dead — restore it.

Optional: enumerate candidates to sweep

To triage the whole surface rather than one package, list declared deps and grep each for an import, then apply steps 2–5 to the ones with zero hits:

node -e "const p=require('./package.json');console.log([...Object.keys(p.dependencies||{}),...Object.keys(p.devDependencies||{})].join('\n'))" \
| while read PKG; do
    hits=$(grep -rl --include=*.ts --include=*.tsx --include=*.js --include=*.jsx --include=*.mjs \
      -e "from ['\"]$PKG" -e "require(['\"]$PKG" redisinsight configs scripts tests 2>/dev/null | grep -vc node_modules)
    [ "$hits" = "0" ] && echo "candidate: $PKG"
  done

This is a first filter only — every candidate still goes through steps 2–5. Expect false positives (config/string/dynamic/ambient use). Never delete straight from this list.

Worked example — jsonpath

  1. Grep across the repo → the only hits were unrelated tutorial text in a manifest.json; no import/require.
  2. Not referenced in any config or script.
  3. npm ls jsonpath → a leaf; it was also the sole reason underscore was installed.
  4. Plain runtime dep, zero references → likely deletable.
  5. Removed jsonpath + @types/jsonpath, npm install, npm run type-check → green. Confirmed dead; committed. (underscore dropped with it.)

Thêm skills từ redis

docs-sync
redis
Phân tích triển khai và cấu hình của nhánh master để tìm tài liệu bị thiếu, sai hoặc lỗi thời trong docs/, README.md và các README theo từng gói. Sử dụng…
official
implement-command
redis
Add a new Redis command (or command variant) to node-redis end-to-end — the `<NAME>.ts` Command file, its registration with JSDoc in the package…
official
maintainer-review
redis
Xem xét một URL issue hoặc pull request trên GitHub với tư cách là người bảo trì node-redis, đánh giá theo từng giai đoạn xem tuyên bố đó có thực tế, quan trọng trong thực tế, đã được…
official
pr-draft-summary
redis
Tạo khối tóm tắt sẵn sàng cho PR, gợi ý nhánh, tiêu đề và mô tả dự thảo cho node-redis. Phải được sử dụng trước phản hồi cuối cùng bất cứ khi nào…
official
runtime-behavior-probe
redis
Lập kế hoạch và thực hiện các cuộc điều tra hành vi thời gian chạy với các tập lệnh thăm dò TypeScript tạm thời, ma trận xác thực, kiểm soát trạng thái và báo cáo ưu tiên phát hiện. Sử dụng…
official
backend
redis
Các mẫu phát triển backend NestJS cho API RedisInsight: cấu trúc module, dịch vụ, bộ điều khiển, DTO, tiêm phụ thuộc và xử lý lỗi. Sử dụng khi…
official
branches
redis
Sử dụng chữ thường, kiểu kebab-case với tiền tố loại và mã định danh issue/ticket. Tên nhánh phải khớp với quy tắc của quy trình GitHub Actions (xem .github/workflows/enforce-branch-name-rules.yml).
official
code-quality
redis
Code-quality standards for RedisInsight: TypeScript strictness, naming conventions (camelCase, PascalCase, UPPER_SNAKE_CASE), linting rules, no `any` without…
official