rfc-check
bởi huggingface
Xác định xem các thay đổi được đề xuất có yêu cầu RFC hay không. Sử dụng khi lập kế hoạch cho các thay đổi quan trọng, trước khi bắt đầu công việc lớn, hoặc khi được hỏi liệu có cần RFC hay không.
npx skills add https://github.com/huggingface/openenv --skill rfc-checkRFC Check
Determine if proposed changes require an RFC (Request for Comments).
Instructions
-
Identify changed files using
git diff --name-onlyor provided context -
Apply RFC criteria:
RFC Required:
- New APIs in
src/openenv/core/ - Breaking changes to existing APIs
- New abstractions or design patterns
- Changes affecting the two-interface model (WebSocket/MCP separation)
- Major architectural decisions
RFC Not Required:
- Bug fixes
- Documentation updates
- Minor refactoring (no API changes)
- New example environments (unless introducing new patterns)
- Dependency updates
- Test additions
- New APIs in
-
Check against existing RFCs in
rfcs/for conflicts or dependencies
Analysis Steps
- List all files being changed
- Identify any files in
src/openenv/core/ - Check for public API signature changes
- Look for new abstractions or patterns
- Review existing RFCs for related decisions
Output Format
## RFC Analysis
### Files Changed
- [list of files]
### Core Files Touched
- [any files in src/openenv/core/, or "None"]
### API Changes
- [any signature changes to public APIs, or "None"]
### New Patterns/Abstractions
- [any new patterns introduced, or "None"]
### Verdict: NOT REQUIRED / RECOMMENDED / REQUIRED
### Reasoning
[Explanation of decision based on criteria above]
### If RFC Needed
- Suggested title: "RFC NNN: [title]"
- Related RFCs: [list any related existing RFCs]
- Key decisions to document: [list]
RFC Template Reference
If an RFC is needed, use the template in rfcs/README.md:
# RFC NNN: Title
**Status**: Draft
**Created**: YYYY-MM-DD
**Authors**: @username
## Summary
[1-2 paragraph overview]
## Motivation
[Problem Statement + Goals]
## Design
[Architecture Overview, Core Abstractions, Key Design Decisions]
## Examples
[Code samples demonstrating usage]